Discuss to review question [PATCH V2 1/2] ASoc:codes:Add Awinic AW883XX audio amplifier driver

[Mark Brown]

On Mon, Oct 24, 2022 at 10:41:03AM +0800, wangweidong.a at awinic.com wrote:
> On Mon, Oct 17, 2022 at 04:09:12PM +0800, wangweidong.a at awinic.com wrote:

> > Then it's not a mute function, the goal of the mute function is to run
> before all the power management code to minimise glitches during power
> management.  Just implement the power management via the standard ASoC power
> 
> > management APIs.

> The essence of calling mute is not switch dsp, but switch PA. We think that
> PA has only two states. When no audio stream enters, turn off the PA and
> turn off the PA's dsp. When the audio stream enters, the PA is turned on,
> and the dsp is turned on at the same time

That's not what the mute function is for, the interface is specifically
for muting the stream while power management changes are going on.  What
you're describing is power management so should be controlled via DAPM.
If your device doesn't have any support for a separate mute function
then it should just not implement anything for that in the driver.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20221024/0c885f56/attachment.sig>