[PATCH] ASoC: Intel: avs: Add missing audio amplifier for KBL

Cezary Rojewski cezary.rojewski at intel.com
Tue Nov 22 19:03:46 CET 2022


On 2022-11-22 1:36 AM, Curtis Malainey wrote:
> On Mon, Nov 21, 2022 at 3:20 PM Alicja Michalska <ahplka19 at gmail.com> wrote:
>>
>> KBL platform is missing the definition of 'max98357a' audio amplifier.
>> This amplifier is used on many KBL Chromebooks, for instance variant
>> 'nami' of 'Google/poppy' baseboard.
> 
> Nami isn't a production device, it was a design, I think you mean "Nautilus"
> 
>>          },
>> +       {
>> +               .id = "MX98357A",
>> +               .drv_name = "avs_max98357a",
>> +               .mach_params = {
>> +                       .i2s_link_mask = AVS_SSP(0),
>> +               },
>> +               .tplg_filename = "max98357a-tplg.bin",
>> +       },
> 
> Cezary/Lukasz did we check nautilus? From what I can see in coreboot
> it should need this.

A bit surprised this entry was not there to begin with.

We have checked several dozen of configurations but I admit, don't 
remember if this concrete one was. Max98357a was first launched with APL 
with the avs-driver, then we moved on to Chell and Lars. As I'm not 
aware of any differences, this should work out of the box with the entry 
appended.


Regards,
Czarek


More information about the Alsa-devel mailing list