[PATCH] ASOC: SOF: Intel: hda-codec: fix possible memory leak in hda_codec_device_init()

Yang Yingliang yangyingliang at huawei.com
Wed Nov 2 02:38:22 CET 2022


Hi,
On 2022/11/2 2:29, Mark Brown wrote:
> On Thu, Oct 20, 2022 at 11:47:52AM +0800, Yang Yingliang wrote:
>> If snd_hdac_device_register() fails, 'codec' is leaked, free it in 
>> snd_hdac_device_exit(). And device_initialize() is called in 
>> snd_hdac_device_init(), it should call put_device() to give up 
>> reference or the name allocated in dev_set_name() is leaked. The 
>> snd_hdac_device_exit() will be called in dev->release(). 
> This doesn't apply against current code, please check and resend.
This is v1, the v2 has already been merged.
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/?h=for-6.1&id=e9441675edc1bb8dbfadacf68aafacca60d65a25

Thanks,
Yang


More information about the Alsa-devel mailing list