[PATCH] [v2] ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio

Terry Chen terry_chen at wistron.corp-partner.google.com
Wed May 11 08:33:00 CEST 2022


Hi Pierre-Louis

> @@ -522,6 +578,14 @@ static struct snd_soc_dai_link
*sof_card_dai_links_create(struct device *dev,
>                               goto devm_err;
>                       }
>                       break;
> +             case LINK_BT:
> +                     ret = create_bt_offload_dai_links(dev, links, cpus,
&id, ssp_bt);
> +                     if (ret < 0) {
> +                             dev_err(dev, "fail to create bt offload dai
links, ret %d\n",
> +                                     ret);

For this point, we just follow Intel member to write for this coding style.
The other component also was the same style.



> > @@ -384,6 +384,14 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_adl_machines[] = {
> >               .sof_fw_filename = "sof-adl.ri",
> >               .sof_tplg_filename = "sof-adl-cs35l41.tplg",
> >       },
> > +     {
> > +             .id = "10134242",
> > +             .drv_name = "adl_mx98360a_cs4242",
> > +             .machine_quirk = snd_soc_acpi_codec_list,
> > +             .quirk_data = &adl_max98360a_amp,
> > +             .sof_fw_filename = "sof-adl.ri",
>
> This  also was the same style with others.
>
> > +             .sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg",
>
> Why would you refer to a topology that uses a different codec?
>

 Because Intel college use the same naming style for the same audio codec.


More information about the Alsa-devel mailing list