[PATCH] ASoC: max98390: Add reset gpio control

Mark Brown broonie at kernel.org
Thu Mar 10 12:29:16 CET 2022


On Thu, Mar 10, 2022 at 08:48:09AM +0000, Sa, Nuno wrote:

> > +	max98390->reset_gpio = of_get_named_gpio(i2c-
> > >dev.of_node,
> > +						"maxim,reset-gpios", 0);

> Why not using devm_gpiod_get_optional()? We could request the pin
> already in the asserted state and make the code slightly better...

Yes, and it'd support other firmware interfaces too.  We also need an
update to the binding document covering the new property.

Might also be worth putting the device into reset when unloading the
driver, though that's not essential.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220310/73516499/attachment.sig>


More information about the Alsa-devel mailing list