[PATCH 2/2] ASoC: codecs: soundwire: call pm_runtime_resume() in component probe

Mark Brown broonie at kernel.org
Fri Jun 17 11:44:50 CEST 2022


On Thu, Jun 16, 2022 at 04:08:25PM -0500, Pierre-Louis Bossart wrote:

> Make sure that the bus and codecs are pm_runtime active when the card
> is registered/created. This avoid timeouts when accessing registers.

> +static int max98373_sdw_probe(struct snd_soc_component *component)
> +{
> +	int ret;
> +
> +	ret = pm_runtime_resume(component->dev);
> +	if (ret < 0 && ret != -EACCES)
> +		return ret;

I'm not clear what the issue is here.  Is something that's accessing the
registers forgetting to do a pm_runtime_get(), or doing that rather than
using pm_runtime_get_sync()?  This doesn't feel safe or robust.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220617/2e2d1946/attachment.sig>


More information about the Alsa-devel mailing list