[PATCH] ALSA: hda/realtek: Enable speaker and mute LEDs for HP laptops

[Kai-Heng Feng]

On Tue, Jul 19, 2022 at 11:27 PM Lucas Tanure
<tanureal at opensource.cirrus.com> wrote:
>
>
> On 7/19/22 15:20, Kai-Heng Feng wrote:
> > Two more HP laptops that use cs35l41 AMP for speaker and GPIO for mute
> > LEDs.
> >
> > So use the existing quirk to enable them accordingly.
> >
> > Signed-off-by: Kai-Heng Feng <kai.heng.feng at canonical.com>
> > ---
> >   sound/pci/hda/patch_realtek.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 2f55bc43bfa9c..cdbee71e83216 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -9109,6 +9109,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> >       SND_PCI_QUIRK(0x103c, 0x89c3, "Zbook Studio G9", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x89c6, "Zbook Fury 17 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x89ca, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> > +     SND_PCI_QUIRK(0x103c, 0x8ad1, "HP EliteBook 840 14 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> > +     SND_PCI_QUIRK(0x103c, 0x8ad2, "HP EliteBook 860 16 inch G9 Notebook PC", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x8a78, "HP Dev One", ALC285_FIXUP_HP_LIMIT_INT_MIC_BOOST),
> >       SND_PCI_QUIRK(0x103c, 0x8aa0, "HP ProBook 440 G9 (MB 8A9E)", ALC236_FIXUP_HP_GPIO_LED),
> >       SND_PCI_QUIRK(0x103c, 0x8aa3, "HP ProBook 450 G9 (MB 8AA1)", ALC236_FIXUP_HP_GPIO_LED),
>
> Hi,
>
> Can you send us the ACPI dump (DSDT file) for review for both laptops?

As attachment.

>
> We want to ensure that the ACPI has the correct information so the
> driver will work properly.

One thing we noticed recently is that _all_ systems that are equipped
with cs35l41 have rather weak speaker output.
Sound is barely audible when the volume is around 50%.

Kai-Heng

>
> Thanks
>
> Lucas Tanure
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DSDT-8ad2
Type: application/octet-stream
Size: 244908 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220720/7363c34e/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: DSDT-8ad1
Type: application/octet-stream
Size: 244908 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220720/7363c34e/attachment-0003.obj>