[PATCH] Revert "ASoC: amd: acp: Power on/off the speaker enable gpio pin based on DAPM callback."

Curtis Malainey cujomalainey at gmail.com
Mon Jan 31 19:39:00 CET 2022


> > --
> > 2.32.0
> >
> I feel instead of reverting this complete patch we can quickly submit a
> new patch set with "gpio_spk_en = NONE" for maxim codec case. As codec
> driver is anyhow controlling that gpio we don't need to do it from
> machine driver. We've already done that here
> https://patchwork.kernel.org/project/alsa-devel/patch/20220131203225.1418648-1-vsujithkumar.reddy@amd.com/

I'm pretty sure the proper solution is to shove this logic into the
alc1019 driver like it is in the max98357 driver. The header is
already there for gpio which makes me think it was planned but
forgotten. Otherwise everyone else who uses this codec and associated
pin will have to duplicate this logic in their machine driver.


More information about the Alsa-devel mailing list