[PATCH] ALSA: usb-audio: initialize variables that could ignore errors

Takashi Iwai tiwai at suse.de
Thu Jan 27 14:41:30 CET 2022


On Wed, 26 Jan 2022 19:21:42 +0100,
trix at redhat.com wrote:
> 
> From: Tom Rix <trix at redhat.com>
> 
> clang static analysis reports this representative issue
> mixer.c:1548:35: warning: Assigned value is garbage or undefined
>         ucontrol->value.integer.value[0] = val;
>                                          ^ ~~~
> 
> The filter_error() macro allows errors to be ignored.
> If errors can be ignored, initialize variables
> so garbage will not be used.
> 
> Fixes: 48cc42973509 ("ALSA: usb-audio: Filter error from connector kctl ops, too")
> Signed-off-by: Tom Rix <trix at redhat.com>

Thanks, applied.


Takashi


More information about the Alsa-devel mailing list