[PATCH 03/13] ASoC: amd: add acp6.2 init/de-init functions

Mark Brown broonie at kernel.org
Fri Aug 12 14:33:29 CEST 2022


On Fri, Aug 12, 2022 at 05:37:21PM +0530, Syed Saba kareem wrote:

> +	/* power on */
> +	ret = acp62_power_on(acp_base);
> +	if (ret) {
> +		pr_err("ACP power on failed\n");
> +		return ret;
> +	}

It would be better if you passed the device in so messages like this
could be dev_err() rather than just pr_err().
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20220812/489b2ee0/attachment.sig>


More information about the Alsa-devel mailing list