[PATCH v2 0/4] ALSA: Defer async signal handling

Jaroslav Kysela perex at perex.cz
Mon Aug 1 10:08:24 CEST 2022


On 28. 07. 22 14:59, Takashi Iwai wrote:
> Hi,
> 
> this is a revised patch series for another attempt to address the
> potential deadlocks via kill_fasync() calls that have been reported by
> syzbot for long time.  Only a missing linux/fs.h inclusion was added
> from v1 series[1].
> 
> Instead of the previous series to drop the async handler[2], this
> tries to defer the kill_fasync() call.  A few new common helpers are
> introduced at first, then the actual usages are replaced in the
> following patches.
> 
> The patches passed the quick tests with alsa-lib test cases.

Thank you for your work. The code looks good (I would only move 
schedule_work() call outside the spin lock context - commented in the patch 
thread).

Reviewed-by: Jaroslav Kysela <perex at perex.cz>

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list