[PATCH] ASoC: cros_ec_codec: Use modern ASoC DAI format terminology

Enric Balletbo i Serra enric.balletbo at collabora.com
Wed Sep 22 12:07:10 CEST 2021


Hi Mark,

On 20/9/21 19:04, Mark Brown wrote:
> As part of moving to remove the old style defines for the bus clocks update
> the cros_ec_codec driver to use more modern terminology for clocking.
> 
> Signed-off-by: Mark Brown <broonie at kernel.org>

Looked at other patches that do the same thing and comparing with those, the
change looks good to me. Also, doesn't seem to affect the device that uses this
codec so.

Reviewed-by: Enric Balletbo i Serra <enric.balletbo at collabora.com>

> ---
>  sound/soc/codecs/cros_ec_codec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
> index a201d652aca2..9b92e1a0d1a3 100644
> --- a/sound/soc/codecs/cros_ec_codec.c
> +++ b/sound/soc/codecs/cros_ec_codec.c
> @@ -283,8 +283,8 @@ static int i2s_rx_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
>  	struct ec_param_ec_codec_i2s_rx p;
>  	enum ec_codec_i2s_rx_daifmt daifmt;
>  
> -	switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> -	case SND_SOC_DAIFMT_CBS_CFS:
> +	switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> +	case SND_SOC_DAIFMT_CBC_CFC:
>  		break;
>  	default:
>  		return -EINVAL;
> 


More information about the Alsa-devel mailing list