[PATCH] ALSA: firewire-motu: fix truncated bytes in message tracepoints

Takashi Iwai tiwai at suse.de
Tue Sep 21 18:49:24 CEST 2021


On Mon, 20 Sep 2021 13:07:34 +0200,
Takashi Sakamoto wrote:
> 
> In MOTU protocol v2/v3, first two data chunks across 2nd and 3rd data
> channels includes message bytes from device. The total size of message
> is 48 bits per data block.
> 
> The 'data_block_message' tracepoints event produced by ALSA firewire-motu
> driver exposes the sequence of messages to userspace in 64 bit storage,
> however lower 32 bits are actually available since current implementation
> truncates 16 bits in upper of the message as a result of bit shift
> operation within 32 bit storage.
> 
> This commit fixes the bug by perform the bit shift in 64 bit storage.
> 
> Fixes: c6b0b9e65f09 ("ALSA: firewire-motu: add tracepoints for messages for unique protocol")
> Cc: <stable at vger.kernel.org>
> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>

Thanks, applied.


Takashi


More information about the Alsa-devel mailing list