[PATCH 3/3] ASoC: rsnd: add null CLOCKIN support

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu May 27 00:06:19 CEST 2021


Hi Geert

> Oh right, I missed the static clk_hw pointer.
> What if you unload the snd-soc-rcar.ko module?

Hmm.. indeed.
It needs something..
Thank you for poining it.

>     #define for_each_rsnd_clk(pos, adg, i)          \
>             for (i = 0; (pos) = adg->clk[i], i < CLKMAX; i++)            \
>                     if (pos) {                      \
>                             continue;               \
>                     } else

Wow!! I didn't know this technique.
Indeed it can use NULL pointer.

But, I want to avoid "if (pos) else" code as much as possible,
and keep simple code.
It can handle all clk case without thinking it if it has null_clk.

Why you don't want null_clk ??

Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list