[PATCH 1/3] ALSA: firewire-lib: drop initial NODATA packets or empty packets

[kernel test robot]

Hi Takashi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on sound/for-next]
[cannot apply to v5.13-rc2 next-20210521]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Takashi-Sakamoto/ALSA-firewire-lib-drop-initial-NODATA-packets-or-empty-packets/20210523-204607
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/a1c11b8ba891b02a7669df5e99ea3f407ee3efb7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Takashi-Sakamoto/ALSA-firewire-lib-drop-initial-NODATA-packets-or-empty-packets/20210523-204607
        git checkout a1c11b8ba891b02a7669df5e99ea3f407ee3efb7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   sound/firewire/amdtp-stream.c: In function 'amdtp_stream_first_callback':
>> sound/firewire/amdtp-stream.c:1376:6: warning: variable 'cycle' set but not used [-Wunused-but-set-variable]
    1376 |  u32 cycle;
         |      ^~~~~


vim +/cycle +1376 sound/firewire/amdtp-stream.c

9b1fcd9bf80206 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1367  
60dd49298ec580 sound/firewire/amdtp-stream.c Takashi Sakamoto 2019-10-18  1368  // this is executed one time.
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1369  static void amdtp_stream_first_callback(struct fw_iso_context *context,
73fc7f080105b1 sound/firewire/amdtp-stream.c Takashi Sakamoto 2016-05-09  1370  					u32 tstamp, size_t header_length,
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1371  					void *header, void *private_data)
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1372  {
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1373  	struct amdtp_stream *s = private_data;
da3623abfbef44 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1374  	struct amdtp_domain *d = s->domain;
26cd1e5850b70b sound/firewire/amdtp-stream.c Takashi Sakamoto 2019-05-21  1375  	const __be32 *ctx_header = header;
a04513f8b1980e sound/firewire/amdtp-stream.c Takashi Sakamoto 2017-03-22 @1376  	u32 cycle;
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1377  
bdaedca74d6293 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1378  	// For in-stream, first packet has come.
bdaedca74d6293 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1379  	// For out-stream, prepared to transmit first packet
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1380  	s->callbacked = true;
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1381  
cc4f8e91c4ed04 sound/firewire/amdtp-stream.c Takashi Sakamoto 2019-03-17  1382  	if (s->direction == AMDTP_IN_STREAM) {
3e106f4f690ef0 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-18  1383  		cycle = compute_ohci_cycle_count(ctx_header[1]);
a04513f8b1980e sound/firewire/amdtp-stream.c Takashi Sakamoto 2017-03-22  1384  
a1c11b8ba891b0 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-23  1385  		context->callback.sc = drop_tx_packets_initially;
a04513f8b1980e sound/firewire/amdtp-stream.c Takashi Sakamoto 2017-03-22  1386  	} else {
3e106f4f690ef0 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-18  1387  		cycle = compute_ohci_it_cycle(*ctx_header, s->queue_size);
26cd1e5850b70b sound/firewire/amdtp-stream.c Takashi Sakamoto 2019-05-21  1388  
da3623abfbef44 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1389  		if (s == d->irq_target)
9b1fcd9bf80206 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1390  			context->callback.sc = irq_target_callback_skip;
2472cfb3232caf sound/firewire/amdtp-stream.c Takashi Sakamoto 2020-05-08  1391  		else
9b1fcd9bf80206 sound/firewire/amdtp-stream.c Takashi Sakamoto 2021-05-20  1392  			context->callback.sc = skip_rx_packets;
a04513f8b1980e sound/firewire/amdtp-stream.c Takashi Sakamoto 2017-03-22  1393  	}
a04513f8b1980e sound/firewire/amdtp-stream.c Takashi Sakamoto 2017-03-22  1394  
73fc7f080105b1 sound/firewire/amdtp-stream.c Takashi Sakamoto 2016-05-09  1395  	context->callback.sc(context, tstamp, header_length, header, s);
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1396  }
7b3b0d8583c926 sound/firewire/amdtp.c        Takashi Sakamoto 2014-04-25  1397  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 66558 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20210523/566b619f/attachment-0001.gz>