[PATCH v2] ASoC: qcom: lpass: Fix i2s ctl register bit map

Stephan Gerhold stephan at gerhold.net
Mon Jan 25 11:30:19 CET 2021


On Wed, Jan 20, 2021 at 10:49:55AM +0800, Jun Nie wrote:
> Fix bitwidth mapping in i2s ctl register per APQ8016 document.
> Fixes: b5022a36d28f ("ASoC: qcom: lpass: Use regmap_field for i2sctl and
> dmactl registers")
> 
> Signed-off-by: Jun Nie <jun.nie at linaro.org>

Thanks for spotting this, I guess this did not cause me problems yet
because I use SNDRV_PCM_FMTBIT_S16 everywhere.

Anyway, this looks correct according to the datasheet:
Reviewed-by: Stephan Gerhold <stephan at gerhold.net>

> ---
>  sound/soc/qcom/lpass-apq8016.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/lpass-apq8016.c b/sound/soc/qcom/lpass-apq8016.c
> index 8507ef8f6679..3efa133d1c64 100644
> --- a/sound/soc/qcom/lpass-apq8016.c
> +++ b/sound/soc/qcom/lpass-apq8016.c
> @@ -250,7 +250,7 @@ static struct lpass_variant apq8016_data = {
>  	.micmode		= REG_FIELD_ID(0x1000, 4, 7, 4, 0x1000),
>  	.micmono		= REG_FIELD_ID(0x1000, 3, 3, 4, 0x1000),
>  	.wssrc			= REG_FIELD_ID(0x1000, 2, 2, 4, 0x1000),
> -	.bitwidth		= REG_FIELD_ID(0x1000, 0, 0, 4, 0x1000),
> +	.bitwidth		= REG_FIELD_ID(0x1000, 0, 1, 4, 0x1000),
>  
>  	.rdma_dyncclk		= REG_FIELD_ID(0x8400, 12, 12, 2, 0x1000),
>  	.rdma_bursten		= REG_FIELD_ID(0x8400, 11, 11, 2, 0x1000),
> -- 
> 2.25.1
> 


More information about the Alsa-devel mailing list