[PATCH v2 3/6] ASoC: samsung: s3c24xx_simtec: add missing error check

Sylwester Nawrocki s.nawrocki at samsung.com
Tue Feb 23 11:57:12 CET 2021


On 22.02.2021 22:33, Pierre-Louis Bossart wrote:
> cppcheck warning:
> 
> sound/soc/samsung/s3c24xx_simtec.c:191:7: style: Variable 'ret' is
> assigned a value that is never used. [unreadVariable]
>   ret = snd_soc_dai_set_clkdiv(cpu_dai, S3C24XX_DIV_PRESCALER,
>       ^
> 
> Looking at the code, it's not clear why the return value is checked in
> the two other cases but not here, so mirror the behavior and add a
> check.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>

Reviewed-by: Sylwester Nawrocki <s.nawrocki at samsung.com>


More information about the Alsa-devel mailing list