[PATCH v2] ASoC: rt1316: Add RT1316 SDCA vendor-specific driver

Jaroslav Kysela perex at perex.cz
Thu Feb 18 10:44:34 CET 2021


Dne 18. 02. 21 v 10:12 shumingf at realtek.com napsal(a):

> +	SND_SOC_DAPM_SWITCH("DAC L", SND_SOC_NOPM, 0, 0, &rt1316_sto_dac_l),
> +	SND_SOC_DAPM_SWITCH("DAC R", SND_SOC_NOPM, 0, 0, &rt1316_sto_dac_r),

Truly, I don't understand the reason to have a separate L/R switch when we can
map this functionality to one stereo (multichannel) control.

It's an issue for all ASoC drivers. We should consider to be more strict for
the new ones.

					Jaroslav

-- 
Jaroslav Kysela <perex at perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.


More information about the Alsa-devel mailing list