[PATCH] ASoC: SOF: fix runtime pm usage mismatch after probe errors

Mark Brown broonie at kernel.org
Wed Feb 10 21:11:36 CET 2021


On Wed, 10 Feb 2021 12:52:37 +0200, Kai Vehmanen wrote:
> With current delayed probe implementation, sof_probe_complete is not
> called in case of errors. And as this function is responsible for
> decrementing runtime pm usage counter, this will result in following
> problem:
> 
>  - probe driver in conditions where probe will fail (to force
>    the condition on Intel SOF systems, set
>    "snd_sof_intel_hda_common.codec_mask=0")
>  - unload driver (runtime-pm usage_count is leaked)
>  - fix the issue by installing missing fw, modifying module parameters,
>    etc actions
>  - try to load driver again -> success, probe ok
>  -> device never enters runtime suspend
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: fix runtime pm usage mismatch after probe errors
      commit: 271d9373db1c76f239fe3124e552b6b58b2af984

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


More information about the Alsa-devel mailing list