[PATCH RESEND 2/2] ASoC: cs4265: Move reset_gpio to local scope

Charles Keepax ckeepax at opensource.cirrus.com
Wed Dec 29 11:00:54 CET 2021


On Wed, Dec 22, 2021 at 11:19:20AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam at denx.de>
> 
> There is no need to keep 'struct gpio_desc *reset_gpio' inside
> the private structure becase reset_gpio is only used inside the
> probe() function.
> 
> Move it to a local scope.
> 
> Signed-off-by: Fabio Estevam <festevam at denx.de>
> ---

Patch looks fine, but I do have a slight doubt would it perhaps
be better to add a remove function that puts the device back into
reset, thus keeping the private member? Feels like it might be a
nicer state to leave the chip in if the driver unbinds.

Thanks,
Charles


More information about the Alsa-devel mailing list