[PATCH] kselftest: alsa: Use private alsa-lib configuration in mixer test

Takashi Sakamoto o-takashi at sakamocchi.jp
Wed Dec 8 14:55:41 CET 2021


On Wed, Dec 8, 2021, at 18:52, Jaroslav Kysela wrote:
> As mentined by Takashi Sakamoto, the system-wide alsa-lib configuration
> may override the standard device declarations. This patch use the private
> alsa-lib configuration to set the predictable environment.
>
> Cc: Mark Brown <broonie at kernel.org>
> Cc: Shuah Khan <shuah at kernel.org>
> Cc: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
> Cc: linux-kselftest at vger.kernel.org
> Link: https://lore.kernel.org/alsa-devel/Ya7TAHdMe9i41bsC@workstation/
> Signed-off-by: Jaroslav Kysela <perex at perex.cz>
> ---
>  tools/testing/selftests/alsa/mixer-test.c | 50 ++++++++++++++++++++++-
>  1 file changed, 49 insertions(+), 1 deletion(-)

I'm not positively for the patch since it can take developers puzzled due to
the symbol dependency newly introduced in unreleased version of alsa-lib.
It's better to check the version of alsa-lib in Makefile to avoid developers’dole
if we have enough respect to embedded developers, especially forced to work
with legacy userspace. (and it often occurs).

As a side note, I think it better to change symbol table (alsa-lib/src/Versions.in)
if introducing new public symbol of c library.


Regards

Takashi Sakamoto


More information about the Alsa-devel mailing list