[PATCH] ASoC: cs35l3x: Use neutral language in amp drivers

Mark Brown broonie at kernel.org
Tue Oct 20 14:09:05 CEST 2020


On Mon, Oct 19, 2020 at 05:44:27PM -0500, David Rhodes wrote:

> -		/* Only certain ratios are supported in I2S Slave Mode */
> -		if (cs35l35->slave_mode) {
> +		/* Only certain ratios are supported in I2S Device Mode */
> +		if (cs35l35->clock_mode) {

> -			/* Only certain ratios supported in I2S MASTER Mode */
> +			/* Only certain ratios supported in I2S Controller Mode */

Your renaming moves this to a boolean variable called clock mode which
maps onto device and controller.  I am not sure people are going to be
able to follow that.  Perhaps clock_source or something?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20201020/8e8663bc/attachment.sig>


More information about the Alsa-devel mailing list