[PATCH 1/6] Add ancillary bus support

Ertman, David M david.m.ertman at intel.com
Thu Oct 1 18:30:35 CEST 2020


> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Thursday, October 1, 2020 4:02 AM
> To: Ertman, David M <david.m.ertman at intel.com>
> Cc: alsa-devel at alsa-project.org; tiwai at suse.de; broonie at kernel.org; pierre-
> louis.bossart at linux.intel.com; Sridharan, Ranjani
> <ranjani.sridharan at intel.com>; jgg at nvidia.com; parav at nvidia.com; Patil,
> Kiran <kiran.patil at intel.com>; Ranjani Sridharan
> <ranjani.sridharan at linux.intel.com>; Fred Oh <fred.oh at linux.intel.com>;
> Saleem, Shiraz <shiraz.saleem at intel.com>; Parav Pandit
> <parav at mellanox.com>; Williams, Dan J <dan.j.williams at intel.com>
> Subject: Re: [PATCH 1/6] Add ancillary bus support
> 
> On Wed, Sep 30, 2020 at 03:50:46PM -0700, Dave Ertman wrote:
> > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
> > index 397e35392bff..1fd238094543 100644
> > --- a/drivers/bus/Makefile
> > +++ b/drivers/bus/Makefile
> > @@ -3,6 +3,9 @@
> >  # Makefile for the bus drivers.
> >  #
> >
> > +#Ancillary bus driver
> 
> Nit, you need a space :)

Fixed for next version 😊

> 
> > +obj-$(CONFIG_ANCILLARY_BUS)	+= ancillary.o
> 
> And why not put this in drivers/base/?  Why way over here in
> drivers/bus?

My only reason was that this is a bus, and I wagered that buses should
go into the bus subdirectory. 😊

> 
> thanks,
> 
> greg k-h

-DaveE


More information about the Alsa-devel mailing list