[PATCH v2 1/2] ASoC: arizona: Fix a wrong free in wm8997_probe

Zhang Qilong zhangqilong3 at huawei.com
Thu Nov 12 13:41:39 CET 2020


In the normal path, we should not free the arizona,
we should return immediately. It will be free when
call remove operation.

Fixes: 31833ead95c2c ("ASoC: arizona: Move request of speaker IRQs into bus probe")
Reported-by: Richard Fitzgerald <rf at opensource.cirrus.com>
Signed-off-by: Zhang Qilong <zhangqilong3 at huawei.com>
Acked-by: Richard Fitzgerald <rf at opensource.cirrus.com>
---
 sound/soc/codecs/wm8997.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/codecs/wm8997.c b/sound/soc/codecs/wm8997.c
index 37e4bb3dbd8a..229f2986cd96 100644
--- a/sound/soc/codecs/wm8997.c
+++ b/sound/soc/codecs/wm8997.c
@@ -1177,6 +1177,8 @@ static int wm8997_probe(struct platform_device *pdev)
 		goto err_spk_irqs;
 	}
 
+	return ret;
+
 err_spk_irqs:
 	arizona_free_spk_irqs(arizona);
 
-- 
2.25.4



More information about the Alsa-devel mailing list