[PATCH 3/3] ASoC: rt5682: Add the descriptions for the DMIC clock rate and delay settings

[Lars-Peter Clausen]

Hi,

On 3/17/20 3:52 AM, Oder Chiou wrote:
> The patch adds the descriptions for the DMIC clock rate and delay settings.
>
> Signed-off-by: Oder Chiou <oder_chiou at realtek.com>
> ---
>   Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
> index ac98151d29e4..0fb8a37d9b55 100644
> --- a/Documentation/devicetree/bindings/sound/rt5682.txt
> +++ b/Documentation/devicetree/bindings/sound/rt5682.txt
> @@ -38,6 +38,12 @@ Optional properties:
>   - clocks : phandle and clock specifier for codec MCLK.
>   - clock-names : Clock name string for 'clocks' attribute, should be "mclk".
>   
> +- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
> +  particular DMIC.
Usually for devicetree property names 'clock' is not abbreviated. So 
'realtek,dmic-clock-rate' might be a better choice. Also mention in the 
description that it is in Hz.
> +
> +- realtek,dmic-delay : Set the delay time for the requirement of the
> +  particular DMIC.

What is the unit of the delay time. Usually for properties for duration 
there is also a suffix indicating the unit. E.g. realtk,dmic-delay-ms.

- Lars