[PATCH 08/14] ASoC: SOF: fix uninitialised "work" with VirtIO

Mark Brown broonie at kernel.org
Fri Mar 13 15:45:28 CET 2020


On Thu, Mar 12, 2020 at 03:44:23PM +0100, Guennadi Liakhovetski wrote:
> In the VirtIO case the sof_pcm_open() function isn't called on the
> host during guest streaming, which then leaves "work" structures
> uninitialised. However it is then used to handle position update
> messages from the DSP. Move their initialisation to immediately after
> allocation of the containing structure.

This is good practice in general, independently of anything you're doing
with VirtIO - it makes it harder to introduce bugs.  I'd split this out
and send it separately.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20200313/207ba7a0/attachment-0001.sig>


More information about the Alsa-devel mailing list