[PATCH 1/3] ALSA: atmel: Remove invalid "fall through" comments

Gustavo A. R. Silva gustavoars at kernel.org
Thu Jul 9 18:33:26 CEST 2020


On Thu, Jul 09, 2020 at 01:17:48PM +0200, Takashi Iwai wrote:
> The comments about fall through in sound/atmel/ac97.c are just
> superfluous and rather confusing.  Let's remove them.
> 

Reviewed-by: Gustavo A. R. Silva <gustavoars at kernel.org>

> Signed-off-by: Takashi Iwai <tiwai at suse.de>
> ---
>  sound/atmel/ac97c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index a62f1cdad68f..1006458f7f85 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -219,7 +219,7 @@ static int atmel_ac97c_playback_prepare(struct snd_pcm_substream *substream)
>  	switch (runtime->format) {
>  	case SNDRV_PCM_FORMAT_S16_LE:
>  		break;
> -	case SNDRV_PCM_FORMAT_S16_BE: /* fall through */
> +	case SNDRV_PCM_FORMAT_S16_BE:
>  		word &= ~(AC97C_CMR_CEM_LITTLE);
>  		break;
>  	default:
> @@ -301,7 +301,7 @@ static int atmel_ac97c_capture_prepare(struct snd_pcm_substream *substream)
>  	switch (runtime->format) {
>  	case SNDRV_PCM_FORMAT_S16_LE:
>  		break;
> -	case SNDRV_PCM_FORMAT_S16_BE: /* fall through */
> +	case SNDRV_PCM_FORMAT_S16_BE:
>  		word &= ~(AC97C_CMR_CEM_LITTLE);
>  		break;
>  	default:
> -- 
> 2.16.4
> 


More information about the Alsa-devel mailing list