[PATCH v5 3/3] ALSA: compress: fix partial_drain completion state

Charles Keepax ckeepax at opensource.cirrus.com
Wed Jul 1 16:20:32 CEST 2020


On Mon, Jun 29, 2020 at 07:17:37PM +0530, Vinod Koul wrote:
> On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING
> state, so set that for partially draining streams in
> snd_compr_drain_notify() and use a flag for partially draining streams
> 
> While at it, add locks for stream state change in
> snd_compr_drain_notify() as well.
> 
> Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)")
> Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
> Tested-by: Srinivas Kandagatla <srinivas.kandagatla at linaro.org>
> Signed-off-by: Vinod Koul <vkoul at kernel.org>
> ---

Worth noting I haven't actually tested the gapless, but keeps all
the compressed capture stuff happy.

Tested-by: Charles Keepax <ckeepax at opensource.cirrus.com>
Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>

Thanks,
Charles


More information about the Alsa-devel mailing list