[alsa-devel] [PATCH v2 07/11] ASoC: SOF: Implement Probe IPC API

Cezary Rojewski cezary.rojewski at intel.com
Tue Jan 28 11:49:43 CET 2020


On 2020-01-27 22:01, Pierre-Louis Bossart wrote:
> 
>> +/**
>> + * sof_ipc_probe_points_remove - disconnect specified probes
>> + * @sdev:    SOF sound device
>> + * @desc:    List of probe points to disconnect
>> + * @num_desc:    Number of elements in @desc
>> + *
>> + * Removes previously connected probes from list of active probe
>> + * points and frees all resources on DSP side.
>> + */
>> +int sof_ipc_probe_points_remove(struct snd_sof_dev *sdev,
>> +        unsigned int *buffer_id, size_t num_buffer_id)
>> +{
> 
> cppcheck warning:
> 
> [sound/soc/sof/probe.h:83] -> [sound/soc/sof/probe.c:265]: (style, 
> inconclusive) Function 'sof_ipc_probe_points_remove' argument 3 names 
> different: declaration 'num_id' definition 'num_buffer_id'.
> 
> cppcheck --platform=unix32 --force --max-configs=1024 --inconclusive 
> --enable=all sound/soc/sof

Thanks for spotting this out Pierre! Warning annihilated in v3.


More information about the Alsa-devel mailing list