[alsa-devel] [PATCH] ASoC: amd: Fix for Subsequent Playback issue.

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Wed Jan 22 01:14:28 CET 2020


Hi Ravulapati

> If we play audio back to back, which kills one playback
> and immediately start another, we can hear clicks.
> This patch fixes the issue.
> 
> Signed-off-by: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati at amd.com>
> ---
(snip)
> +	kfree(rtd);

Please double check soc_new_pcm_runtime() and
soc_free_pcm_runtime() at soc-core.c.
Because rtd is created via devm_kzalloc(),
and has many related resources which need to be cared when rtd was freed.
Just kfree() is not good/enough, I think.

I think you want to use is snd_soc_remove_pcm_runtime()
instead of kfree()

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list