[PATCH 6/8] ASoC: soc-pcm: check DAI's activity more simply

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Feb 27 03:34:47 CET 2020


Hi Pierre-Louis, again

> > Not in this case though, the initial idea was to do the mute when only
> > playback or capture were enabled? If you mute when both are enabled
> > then that's a real change.
> 
> Let's check original
> 
> 	if ((playback && playback_active == 1) ||
> 	    (!playback && capture_active == 1))
> 		snd_soc_dai_digital_mute(...)
> 
> It calls mute if Playback or Capture is working.
> and my patch (v2) is
> 
> 	if (codec_dai->activity)
> 		snd_soc_dai_digital_mute(...)
> 
> It calls mute if Codec DAI is working (= Playback or Capture).
> I think it doesn't change behavior.

Oops !
I was wrong. I will post mail to v2 patch for detail

Thank you for your help !!
Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list