[alsa-devel] [PATCH v1 4/4] ALSA: hda - Fix DP-MST support for NVIDIA codecs

Takashi Iwai tiwai at suse.de
Tue Feb 4 08:48:45 CET 2020


On Tue, 04 Feb 2020 08:20:17 +0100,
Nikhil Mahale wrote:
> 
> If dyn_pcm_assign is set, different jack objects are being created
> for pcm and pins.
> 
> If dyn_pcm_assign is set, generic_hdmi_build_jack() calls into
> add_hdmi_jack_kctl() to create and track separate jack object for
> pcm. Like sync_eld_via_acomp(), hdmi_present_sense_via_verbs() also
> need to report status change of the pcm jack.
> 
> Rename pin_idx_to_jack() to pin_idx_to_pcm_jack(). Update
> hdmi_present_sense_via_verbs() to report plug state of pcm jack
> object. Unlike sync_eld_via_acomp(), for !acomp drivers the pcm
> jack's plug state must be consistent with plug state
> of pin's jack.
> 
> Fixes: 5398e94fb753 ALSA: hda - Add DP-MST support for NVIDIA codecs

It's a wrong format.  It should be Fixes: xxxx ("blah blah")

> Signed-off-by: Nikhil Mahale <nmahale at nvidia.com>

As mentioned in the previous post, the fix must be applicable to 5.5
kernel as it's a clear regression.  Get it fixed at first, then go for
cleanup the rest.


thanks,

Takashi


More information about the Alsa-devel mailing list