[PATCH 4/4] regmap: sdw: add support for SoundWire 1.2 MBQ

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Aug 26 18:57:11 CEST 2020


>> +#include <linux/device.h>
>> +#include <linux/errno.h>
>> +#include <linux/mod_devicetable.h>
> 
> Curious why do you need this header?

I'll return the question back to you, since you added this header for 
regmap-sdw.c:

7c22ce6e21840 (Vinod Koul           2018-01-08 15:50:59 +0530  6) 
#include <linux/mod_devicetable.h>

so I assumed it was needed here as well.

>> +MODULE_DESCRIPTION("Regmap SoundWire Module");
> 
> This is same of sdw module, pls make this one a bit different.

yes, fixed.


More information about the Alsa-devel mailing list