[PATCH] ALSA: usb-audio: Fix memleak in scarlett2_add_new_ctl

dinghao.liu at zju.edu.cn dinghao.liu at zju.edu.cn
Fri Aug 7 11:50:13 CEST 2020



"Takashi Iwai" <tiwai at suse.de>写道:
> On Fri, 07 Aug 2020 09:12:27 +0200,
> Dinghao Liu wrote:
> > 
> > When snd_usb_mixer_add_control() fails, elem needs to be
> > freed just like when snd_ctl_new1() fails. However, current
> > code is returning directly and ends up leaking memory.
> 
> No, this would lead to double-free.  snd_ctl_add() shows a kind of
> special behavior, it already releases the object at its error path.
> 

It's clear to me, thanks!

Regards,
Dinghao


More information about the Alsa-devel mailing list