[PATCH v2 0/3] add channel constraint for BDW machine drivers

Cezary Rojewski cezary.rojewski at intel.com
Mon Apr 27 22:00:40 CEST 2020


On 2020-04-27 19:13, Brent Lu wrote:
> The machine driver bdw-rt5650 (for Google buddy) supports 2 or 4-channel
> recording while other two drivers support only 2-channel recording. HW
> constraints are implemented to reflect the hardware limitation on BDW
> platform.
> 
> Changes since v1:
> - Change the patch title.
> - Remove the DUAL_CHANNEL and QUAD_CHANNEL macros which are too obvious.
> - Follow the naming convertion, using 'bdw_rt5650_' and 'bdw_rt5677_' to
>    name startup functions.
> - Refine the comments in startup functions.
> - Redesign the bdw_rt5650_fe_startup() function for readability.
> - Add an assignment to initialize runtime->hw.channels_max variable.
> 

Thank you for addressing all listed issues.
I'll recheck hw constraints on my end just to be sure but this series 
looks good already, so:

Acked-by: Cezary Rojewski <cezary.rojewski at intel.com>


More information about the Alsa-devel mailing list