[bug report] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers

Dan Carpenter dan.carpenter at oracle.com
Fri Apr 24 12:20:08 CEST 2020


Hello Shengjiu Wang,

This is a semi-automatic email about new static checker warnings.

The patch 955ac624058f: "ASoC: fsl_easrc: Add EASRC ASoC CPU DAI
drivers" from Apr 16, 2020, leads to the following Smatch complaint:

    sound/soc/fsl/fsl_easrc.c:1529 fsl_easrc_hw_free()
    warn: variable dereferenced before check 'ctx' (see line 1527)

sound/soc/fsl/fsl_easrc.c
  1526		struct fsl_asrc_pair *ctx = runtime->private_data;
  1527		struct fsl_easrc_ctx_priv *ctx_priv = ctx->private;
                                                      ^^^^^
Dereference

  1528	
  1529		if (ctx && (ctx_priv->ctx_streams & BIT(substream->stream))) {
                    ^^^
This check is too late, to prevent a NULL dereference.

  1530			ctx_priv->ctx_streams &= ~BIT(substream->stream);
  1531			fsl_easrc_release_context(ctx);

regards,
dan carpenter


More information about the Alsa-devel mailing list