[PATCH 10/17] ASoC: soc-dai: add snd_soc_dai_compr_shutdown()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Apr 23 03:46:13 CEST 2020


Hi Ranjani

Thank you for reviwing

> > From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > 
> > dai related function should be implemented at soc-dai.c.
> > This patch adds snd_soc_dai_compr_shutdown().
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> > ---
(snip)
> > +void snd_soc_dai_compr_shutdown(struct snd_soc_dai *dai,
> > +				struct snd_compr_stream *cstream)
> > +{
> > +	if (dai->driver->cops &&
> > +	    dai->driver->cops->shutdown)
> > +		dai->driver->cops->shutdown(cstream, dai);
> I see the original code doesnt check the return value. But I think we
> should here, no?

Yes, indeed.
But it is shutdown function.
Just reporting dev_err() is enough I think.
What do you think ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list