[alsa-devel] [PATCH] ASoC: core: delete component->card_list in soc_remove_component only

[Kuninori Morimoto]

Hi Bard

Thank you for your patch

> From: Bard Liao <yung-chuan.liao at linux.intel.com>
> 
> We add component->card_list in the end of soc_probe_component(). In
> other words, component->card_list will not be added if there is an
> error in the soc_probe_component() function. So we can't delete
> component->card_list in the error handling of soc_probe_component().
> 
> Fixes: 22d1423187e5 ("ASoC: soc-core: add soc_cleanup_component()")
> Signed-off-by: Bard Liao <yung-chuan.liao at linux.intel.com>
> ---

Hmm... what happen if you get error at soc_probe_component() ?
What does your "can't delete component->card_list" mean ?
Kernel Oops or warning ?

I tried to create an error on purpose at soc_probe_component(),
but, there was no kernel oops, no warning, etc.
It just can't create sound card. It is very normal for me.
Or, which kernel are you using ?

Thank you for your help !!
Best regards
---
Kuninori Morimoto