[alsa-devel] [ALSA patch] [PATCH 5/5] pcm: Update pcm->avail_min with needed_slave_avail_min, after reading unaligned frames

Takashi Iwai tiwai at suse.de
Thu May 2 18:01:17 CEST 2019


On Tue, 30 Apr 2019 09:38:43 +0200,
<vanitha.channaiah at in.bosch.com> wrote:
> 
> From: Vanitha Channaiah <vanitha.channaiah at in.bosch.com>
> 
> Issue: After partial read of unaligned frames, snd_pcm_wait()
> would block for the pcm->avail_min which would result in
> blocking of snd_pcm_wait() for longer periods i.e more than
> one period as specified by avail_min
> 
> Fix: After reading unaligned frames, set the pcm->avail_min
> to the needed available frames so that snd_pcm_wait() blocks till
> needed available frames.
> Once needed available frames are read, set back the original
> pcm->avail_min
> 
> Signed-off-by: Vanitha Channaiah <vanitha.channaiah at in.bosch.com>

This kind of changes in the core code should be avoided as much as
possible, especially if it's only relevant with the specific plugins.

Sorry, this isn't convincing enough.  If this is a MUST, please
clarify better.


thanks,

Takashi


More information about the Alsa-devel mailing list