[alsa-devel] [RFC PATCH 29/40] soundwire: intel_init: add kernel module parameter to filter out links

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Fri Jul 26 16:43:33 CEST 2019



On 7/26/19 5:30 AM, Cezary Rojewski wrote:
> On 2019-07-26 01:40, Pierre-Louis Bossart wrote:
>> @@ -83,6 +87,9 @@ static struct sdw_intel_ctx
>>       caps = ioread32(res->mmio_base + SDW_SHIM_BASE + SDW_SHIM_LCAP);
>>       caps &= GENMASK(2, 0);
>> +    dev_dbg(&adev->dev, "SoundWire links: BIOS count %d hardware caps 
>> %d\n",
>> +        count, caps);
>> +
>>       /* Check HW supported vs property value and use min of two */
>>       count = min_t(u8, caps, count);
> 
> This message does not look like it belongs to current patch - no 
> link_mask dependency whatsoever. There have been couple "informative" 
> patches in your series, maybe schedule it with them instead (as a 
> separate series)?

You're right, this log should be in a different patch. it was added when 
I was debugging the DisCo properties a couple of months back and should 
be moved. thanks for noting this.


More information about the Alsa-devel mailing list