[alsa-devel] [PATCH 1/2] ASoC: pcm512x: Implement the set_bclk_ratio interface

[Dimitris Papavasiliou]

Many thanks for reviewing (and applying) this Mark and equally
many thanks to everyone who took the time to provide feedback!

On 1/28/19 2:10 PM, Mark Brown wrote:
> On Sat, Jan 26, 2019 at 09:00:09PM +0200, Dimitris Papavasiliou wrote:
>> On 1/26/19 8:48 PM, Peter Rosin wrote:
> 
>>> ratio == 0 should also generate -EINVAL.
> 
>> Sorry, I forgot to mention in the notes, that I allowed setting a
>> zero ratio on purpose, in order to allow "unsetting" the bclk
>> ratio (since it only takes effect if it is positive).  I'm not
>> sure if it will ever be necessary to do that in practice, but I
>> thought I'd allow it, since it has a valid effect.
> 
> This is fairly idiomatic for ASoC FWIW.
>