[alsa-devel] [PATCH 2/2] ASoC: Intel: Common: Enable kbl_da7219_max98373 ACPI match

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Tue Jan 22 20:51:03 CET 2019


> diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> index e6fa6f4..cab841d 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> @@ -37,6 +37,11 @@
>   	.codecs = {"MX98927"}
>   };
>   
> +static struct snd_soc_acpi_codecs kbl_7219_98373_codecs = {
> +	.num_codecs = 1,
> +	.codecs = {"MX98373"}
> +};
> +
>   struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
>   	{
>   		.id = "INT343A",
> @@ -106,6 +111,14 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
>   		.drv_name = "kbl_rt5660",
>   		.fw_filename = "intel/dsp_fw_kbl.bin",
>   	},
> +	{
> +		.id = "DLGS7219",
> +		.drv_name = "kbl_da7219_max98373",
> +		.fw_filename = "intel/dsp_fw_kbl.bin",
> +		.machine_quirk = snd_soc_acpi_codec_list,
> +		.quirk_data = &kbl_7219_98373_codecs,
> +		.pdata = &skl_dmic_data

You provided a machine driver that can work with or without DA7219, so 
can you please clarify how the model without DA7219 is handled if you 
use the DA7219 as a primary key for the ACPI search? My current 
understanding is that the driver name "kbl_max98373" will never be used.




More information about the Alsa-devel mailing list