[alsa-devel] [PATCH] ALSA: usb-audio: Add SMSL D1 to quirks for native DSD support

[Takashi Iwai]

On Mon, 21 Jan 2019 17:33:22 +0100,
Jussi Laako wrote:
> 
> On 28.11.2018 22.16, Tony Das wrote:
> > This patch adds quirk VID/PID IDs for the SMSL D1 in order to enable
> > Native DSD support.
> >
> > Signed-off-by: Tony Das <tdas444 at gmail.com>
> > ---
> > Author: Tony Das <tdas444 at gmail.com>
> > Date: Tue Nov 27 22:13:30 2018 +0000
> >
> > diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> > index 3d0f09108c98..aeac6bb7e111 100644
> > --- a/sound/usb/quirks.c
> > +++ b/sound/usb/quirks.c
> > @@ -1515,6 +1515,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct
> > snd_usb_audio *chip,
> >     case USB_ID(0x27f7, 0x3002): /* W4S DAC-2v2SE */
> >     case USB_ID(0x29a2, 0x0086): /* Mutec MC3+ USB */
> >     case USB_ID(0x6b42, 0x0042): /* MSB Technology */
> > +   case USB_ID(0x152a, 0x85de): /* SMSL D1 DAC */
> >         if (fp->altsetting == 3)
> >             return SNDRV_PCM_FMTBIT_DSD_U32_BE;
> >         break;
> 
> These kind of device specific white-listing patches are unnecessary
> these days for VID 0x152a (Thesycon), 0x20b1 (XMOS) and 0x25ce (Mytek)
> because they are covered by the auto-detection code (below this
> whitelisting table). In fact, for some products they cause problems
> due to firmware changes that cause the DSD altsetting to change. Also
> there are vendors who use same VID:PID pair for multiple products with
> different firmware variants and different altsettings which in turn
> causes problems with these static altsetting listings.
> 
> So I would strongly advise to use the autodetection whenever
> possible. In my own kernel builds I've removed all those mentioned
> VIDs from the PID specific table, but for the already included patches
> I took more conservative approach and removed only the ones I could
> 100% test myself.

Care to send a cleanup patch?  That'll be really helpful.


thanks,

Takashi