[alsa-devel] [PATCH v3 07/14] ASoC: SOF: Add DSP firmware logger support

Pierre-Louis Bossart pierre-louis.bossart at linux.intel.com
Wed Jan 9 22:39:54 CET 2019


On 1/9/19 2:44 PM, Mark Brown wrote:
> On Tue, Dec 11, 2018 at 03:23:11PM -0600, Pierre-Louis Bossart wrote:
>
>> +	/* make sure count is <= avail */
>> +	count = avail > count ? count : avail;
> min()?

I tried to use min() but then Sparse started complaining so went back to 
an explicit test+assign.

I don't have a strong opinion on this, but we've found so many 
improvements with the tools that I tend to favor warning-free code.




More information about the Alsa-devel mailing list