[alsa-devel] [PATCH] ALSA: usb-audio: remove some dead code

Dan Carpenter dan.carpenter at oracle.com
Mon Aug 26 15:45:50 CEST 2019


We recently cleaned up the error handling in commit 52c3e317a857 ("ALSA:
usb-audio: Unify the release of usb_mixer_elem_info objects") but
accidentally left this stray return.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
 sound/usb/mixer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c
index a0468c4a6326..a607577f0097 100644
--- a/sound/usb/mixer.c
+++ b/sound/usb/mixer.c
@@ -2633,7 +2633,6 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid,
 		usb_audio_err(state->chip, "cannot malloc kcontrol\n");
 		err = -ENOMEM;
 		goto error_name;
-		return -ENOMEM;
 	}
 	kctl->private_value = (unsigned long)namelist;
 	kctl->private_free = usb_mixer_selector_elem_free;
-- 
2.20.1



More information about the Alsa-devel mailing list