[alsa-devel] [PATCH] ALSA: usb-audio: Fix a memory leak bug

Takashi Iwai tiwai at suse.de
Sun Apr 28 09:12:15 CEST 2019


On Sat, 27 Apr 2019 08:06:46 +0200,
Wenwen Wang wrote:
> 
> In parse_audio_selector_unit(), the string array 'namelist' is allocated
> through kmalloc_array(), and each string pointer in this array, i.e.,
> 'namelist[]', is allocated through kmalloc() in the following for loop.
> Then, a control instance 'kctl' is created by invoking snd_ctl_new1(). If
> an error occurs during the creation process, the string array 'namelist',
> including all string pointers in the array 'namelist[]', should be freed,
> before the error code ENOMEM is returned. However, the current code does
> not free 'namelist[]', resulting in memory leaks.
> 
> To fix the above issue, free all string pointers 'namelist[]' in a loop.
> 
> Signed-off-by: Wenwen Wang <wang6495 at umn.edu>

Applied now, thanks.


Takashi


More information about the Alsa-devel mailing list