[alsa-devel] [PATCH] ASoC: DA7219: Fix failure in hw_params by not letting set_rate error out

Agrawal, Akshu Akshu.Agrawal at amd.com
Mon Apr 22 08:14:07 CEST 2019


We need to set minimum bclk 64x of wclk as this is hw constraint in one
of the component used.
Since, clk_set_rate and clk is enabled in machine driver the
clk_set_rate in hw_params of da7219 fails and errors out and when it
tries to override the value.

In cases like these not only clk_set_rate of da7219 codec should fail
and not override the value but also should not error out.

Signed-off-by: Akshu Agrawal <akshu.agrawal at amd.com>
---
 sound/soc/codecs/da7219.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 5f5fa3416af3..a041dbf442af 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -1621,13 +1621,7 @@ static int da7219_hw_params(struct snd_pcm_substream *substream,
 
 		if (bclk) {
 			bclk_rate = frame_size * sr;
-			ret = clk_set_rate(bclk, bclk_rate);
-			if (ret) {
-				dev_err(component->dev,
-					"Failed to set BCLK rate %lu: %d\n",
-					bclk_rate, ret);
-				return ret;
-			}
+			clk_set_rate(bclk, bclk_rate);
 		} else {
 			ret = da7219_set_bclks_per_wclk(component, frame_size);
 			if (ret) {
-- 
2.17.1



More information about the Alsa-devel mailing list