[alsa-devel] [PATCH 1/2] regmap: soundwire: fix Kconfig select/depend issue

Takashi Iwai tiwai at suse.de
Fri Apr 12 16:21:01 CEST 2019


On Fri, 12 Apr 2019 16:18:41 +0200,
Mark Brown wrote:
> 
> On Fri, Apr 12, 2019 at 09:07:41AM -0500, Pierre-Louis Bossart wrote:
> 
> >  config CODEC_XYX_SDW
> > 	 tristate "XYZ SDW Codec"
> >          depends on SOUNDWIRE
> >          select REGMAP_SOUNDWIRE
> 
> That looks good.
> 
> >  config REGMAP_SOUNDWIRE
> >          select SOUNDWIRE_BUS
> 
> > it'd follow the typical pattern seen in sound/soc/codecs/Kconfig:
> 
> IIRC the select here won't actually do anything.

I thought it'd do select SOUNDWIRE_BUS.  The depends-on here would be
ignored instead.


Takashi


More information about the Alsa-devel mailing list