[alsa-devel] [PATCH v3 01/12] ASoC: intel: boards: define some general functions for hdac_hdmi

Takashi Iwai tiwai at suse.de
Thu Apr 11 16:47:42 CEST 2019


On Thu, 11 Apr 2019 16:19:49 +0200,
libin.yang at intel.com wrote:
> 
> +static int hdac_hdmi_add_device_link(struct device *consumer,
> +				     struct device *supplier,
> +				     struct device_link **link)

Missing inline?

But, before sending v4, please hold on.

I'm thinking whether we can do this rather in the component init of
the hdac-hdmi codec driver.  Can't we get the machine device somehow
at the time of codec component init?

Or even if it's too early, there is also late_probe callback that is
called after binding all...  If we can manage to create a link from
the codec side, we need to change only one place, instead of
scattering allover the tree.


thanks,

Takashi


More information about the Alsa-devel mailing list