[alsa-devel] [PATCH v2 08/12] ASoC: intel: kbl_rt5660: add device_link to HDMI audio

libin.yang at intel.com libin.yang at intel.com
Thu Apr 11 16:09:49 CEST 2019


From: Libin Yang <libin.yang at intel.com>

In resume from S3, HDAC HDMI codec driver dapm event callback may be
operated before HDMI codec driver turns on the display audio power
domain because of the contest between display driver and hdmi codec driver.

This patch adds the device_link between kbl_rt5660 machine device
(consumer) and hdmi codec device (supplier) to make sure the sequence is
always correct.

Signed-off-by: Libin Yang <libin.yang at intel.com>
---
 sound/soc/intel/boards/kbl_rt5660.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/boards/kbl_rt5660.c b/sound/soc/intel/boards/kbl_rt5660.c
index 3255e00..e681984 100644
--- a/sound/soc/intel/boards/kbl_rt5660.c
+++ b/sound/soc/intel/boards/kbl_rt5660.c
@@ -23,6 +23,7 @@
 
 #include "../../codecs/hdac_hdmi.h"
 #include "../../codecs/rt5660.h"
+#include "hdac_hdmi_common.h"
 
 #define KBL_RT5660_CODEC_DAI "rt5660-aif1"
 #define DUAL_CHANNEL 2
@@ -41,6 +42,7 @@ struct kbl_hdmi_pcm {
 struct kbl_codec_private {
 	struct gpio_desc *gpio_lo_mute;
 	struct list_head hdmi_pcm_list;
+	struct device_link *link;
 };
 
 enum {
@@ -222,7 +224,8 @@ static int kabylake_hdmi_init(struct snd_soc_pcm_runtime *rtd, int device)
 
 	list_add_tail(&pcm->head, &ctx->hdmi_pcm_list);
 
-	return 0;
+	/* Setup a device_link between machine device and HDMI codec device. */
+	return hdac_hdmi_add_device_link(rtd->card->dev, dai->dev, &ctx->link);
 }
 
 static int kabylake_hdmi1_init(struct snd_soc_pcm_runtime *rtd)
-- 
2.7.4



More information about the Alsa-devel mailing list